[webkit-reviews] review granted: [Bug 100303] [EFL] Fix failure to highlight nodes on web inspector : [Attachment 170836] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 30 22:52:24 PDT 2012
Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Seokju Kwon
<seokju.kwon at samsung.com>'s request for review:
Bug 100303: [EFL] Fix failure to highlight nodes on web inspector
https://bugs.webkit.org/show_bug.cgi?id=100303
Attachment 170836: Patch
https://bugs.webkit.org/attachment.cgi?id=170836&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170836&action=review
>> Source/WebKit/efl/ewk/ewk_view_single.cpp:276
>> + if (page) {
>
> WebKit prefers to use early return.
As we talk in private, we can't return early in this case. If we do early
return, remaining functions won't be called.
More information about the webkit-reviews
mailing list