[webkit-reviews] review granted: [Bug 100658] [chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build : [Attachment 171209] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 29 11:16:58 PDT 2012


Tony Chang <tony at chromium.org> has granted jochen at chromium.org's request for
review:
Bug 100658: [chromium] TestRunner needs to compile ChromiumCurrentTime and
ChromiumThreading in components build
https://bugs.webkit.org/show_bug.cgi?id=100658

Attachment 171209: Patch
https://bugs.webkit.org/attachment.cgi?id=171209&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171209&action=review


> Tools/ChangeLog:10
> +	   * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

You can add extra notes about the code change here.  For example, it would have
been helpful if you wrote that include_dirs and dependencies is redundant here
because TestRunner already has these settings.


More information about the webkit-reviews mailing list