[webkit-reviews] review granted: [Bug 100665] [Qt][WK2] Remove ViewportUpdateDeferrer from PageViewportController : [Attachment 171281] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 100665: [Qt][WK2] Remove ViewportUpdateDeferrer from PageViewportController
https://bugs.webkit.org/show_bug.cgi?id=100665

Attachment 171281: Patch
https://bugs.webkit.org/attachment.cgi?id=171281&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171281&action=review


For some reasons this makes me afraid that as the code evolves we'll get cases
where the contents is left suspended. That might be because the current code
was over protective too.
Let's test it hard and make sure that it won't happen for 5.0, worst case we
can add protection later.

> Source/WebKit2/UIProcess/qt/PageViewportControllerClientQt.cpp:458
> +    // Should always resume the content, even if no animation was performed.


Maybe write it something like "This should" or "This will take care or
resuming". I wasn't sure if you meant that we should do it here or if it's
expected from animateContentRectVisible until I went back to read your comment
on the bug report.