[webkit-reviews] review denied: [Bug 100516] Web Inspector: Make compact mode the only toolbar mode. : [Attachment 171190] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied dubroy at chromium.org's request
for review:
Bug 100516: Web Inspector: Make compact mode the only toolbar mode.
https://bugs.webkit.org/show_bug.cgi?id=100516

Attachment 171190: Patch
https://bugs.webkit.org/attachment.cgi?id=171190&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171190&action=review


Overall looks good. Why do we need the dock-to-bottom style?

> Source/WebCore/inspector/front-end/helpScreen.css:10
> +body.dock-to-bottom .help-window-outer {

This will now be the same for all modes, just inline the .compact overrides
into the main rules.

> Source/WebCore/inspector/front-end/helpScreen.css:27
> +body.dock-to-bottom .help-window-main {

ditto

> Source/WebCore/inspector/front-end/helpScreen.css:94
> +body.dock-to-bottom .help-content {

ditto

> Source/WebCore/inspector/front-end/helpScreen.css:250
> +body:not(.dock-to-bottom) #settings-screen .tabbed-pane {

ditto

> Source/WebCore/inspector/front-end/inspector.css:108
>  .toolbar-icon {

Here you do as I suggest, why didn't you do it for the help screen above?