[webkit-reviews] review granted: [Bug 99941] Web Inspector: Pipe requests through to Inspector in order to add "initiator" links to messages. : [Attachment 171204] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Mike West
<mkwst at chromium.org>'s request for review:
Bug 99941: Web Inspector: Pipe requests through to Inspector in order to add
"initiator" links to messages.
https://bugs.webkit.org/show_bug.cgi?id=99941

Attachment 171204: Patch
https://bugs.webkit.org/attachment.cgi?id=171204&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=171204&action=review


> Source/WebCore/dom/ScriptExecutionContext.h:86
> +    void addConsoleMessage(MessageSource, MessageType, MessageLevel, const
String& message, const String& sourceURL = String(), unsigned lineNumber = 0,
PassRefPtr<ScriptCallStack> = 0, unsigned long requestIdentifier = 0);

Are there any immediate clients for this one?

> Source/WebCore/inspector/InspectorConsoleAgent.cpp:159
> +    String requestId = requestIdentifier ?
IdentifiersFactory::requestId(requestIdentifier) : String();

You could push this further and make ConsoleMessage constructor accept unsigned
long. You would be able to leave more code below as is then.