[webkit-reviews] review granted: [Bug 100471] [Chromium-Win] Support shortTimeFormat : [Attachment 170835] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 100471: [Chromium-Win] Support shortTimeFormat
https://bugs.webkit.org/show_bug.cgi?id=100471

Attachment 170835: Patch
https://bugs.webkit.org/attachment.cgi?id=170835&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170835&action=review


> Source/WebCore/platform/text/LocaleWin.cpp:709
> +    if (!m_timeFormatWithoutSeconds.isNull())

I'm a bit confused that you're sometimes using isNull() and sometimes
isEmpty(). Here m_timeFormatWithoutSeconds can be an Empty string, which is one
of valid results, so you are using isNull(), right?