[webkit-reviews] review granted: [Bug 100386] [Qt] Enable JSC's disassembler on x86, x86_64 Linux : [Attachment 170671] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Gabor Ballabas
<gaborb at inf.u-szeged.hu>'s request for review:
Bug 100386: [Qt] Enable JSC's disassembler on x86, x86_64 Linux
https://bugs.webkit.org/show_bug.cgi?id=100386

Attachment 170671: Patch
https://bugs.webkit.org/attachment.cgi?id=170671&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170671&action=review


LGTM, but I suggest to use an if() before landing.

> Source/JavaScriptCore/DerivedSources.pri:108
> +linux-*:isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64") {

I suggest to write this as

    linux-*:if(isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64")) {

to be on the very safe side.

> Source/JavaScriptCore/JavaScriptCore.pri:42
> +linux-*:isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64") {

Same here