[webkit-reviews] review granted: [Bug 99351] [GTK][Soup] Implement the default authentication dialog via WebCoreSupport : [Attachment 169936] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 99351: [GTK][Soup] Implement the default authentication dialog via
WebCoreSupport
https://bugs.webkit.org/show_bug.cgi?id=99351

Attachment 169936: Patch
https://bugs.webkit.org/attachment.cgi?id=169936&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169936&action=review


Excellent!

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:672
> -static void setSoupRequestInitiaingPageID(SoupRequest* request, uint64_t
initiatingPageID)
> +static void setSoupRequestInitiaingPageID(SoupRequest* request,
NetworkingContext* context)

The name looks a bit weird now that it doesn't receive a page id, maybe
setSoupRequestInitiaingPageIDFromContext or something similar.