[webkit-reviews] review granted: [Bug 100129] Move appendAsLDMLLiteral in LocaleWin.cpp to a common place : [Attachment 170174] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 23 08:57:30 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 100129: Move appendAsLDMLLiteral in LocaleWin.cpp to a common place
https://bugs.webkit.org/show_bug.cgi?id=100129

Attachment 170174: Patch
https://bugs.webkit.org/attachment.cgi?id=170174&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170174&action=review


OK

> Source/WebCore/ChangeLog:9
> +	   related to DateTimeFormat class.  So we move it to DateTimeForma

Typo: DateTimeForma => DateTimeFormat.

> Source/WebCore/ChangeLog:10
> +	   class as quoteAndAppendLiteral.

Nit: I would slightly prefer appendLiteralAndQuote(). (It's up to you.)


More information about the webkit-reviews mailing list