[webkit-reviews] review granted: [Bug 99964] [chromium] introduce WebTask to the TestRunner library : [Attachment 169951] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 99964: [chromium] introduce WebTask to the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=99964

Attachment 169951: Patch
https://bugs.webkit.org/attachment.cgi?id=169951&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169951&action=review


Much better.  Thank you!

> Tools/DumpRenderTree/chromium/Task.cpp:59
> +	   delete m_task;

We can't use OwnPtr here?

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:56
> +    virtual void postTask(WebTask*) = 0;
> +    virtual void postDelayedTask(WebTask*, long long ms) = 0;

I would add a comment explaining that the delegate takes ownership of the task
object.