[webkit-reviews] review granted: [Bug 99861] RenderTableCol::computePreferredLogicalWidths and RenderTableCol::layout should never be called : [Attachment 169952] Updated patch: also changed layout(). Added a test for a case the previous patch broke.

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 99861: RenderTableCol::computePreferredLogicalWidths and
RenderTableCol::layout should never be called
https://bugs.webkit.org/show_bug.cgi?id=99861

Attachment 169952: Updated patch: also changed layout(). Added a test for a
case the previous patch broke.
https://bugs.webkit.org/attachment.cgi?id=169952&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169952&action=review


> Source/WebCore/rendering/RenderTable.cpp:381
> +    // We ignore table col / colgroup in this iteration as they are used to
size the cell's widths during auto / fixed table layout.

s/as they are/as they are only/ ?

> Source/WebCore/rendering/RenderTableCol.cpp:136
> +    // Also we don't clear any flags, which may never mark the table.

Don't understand this sentence. Please clarify.