[webkit-reviews] review granted: [Bug 99053] [Qt] Handle synchronous GET of blob URLs : [Attachment 168691] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 99053: [Qt] Handle synchronous GET of blob URLs
https://bugs.webkit.org/show_bug.cgi?id=99053

Attachment 168691: Patch
https://bugs.webkit.org/attachment.cgi?id=168691&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168691&action=review


r=me with one minor question.

> Source/WebCore/platform/network/qt/ResourceHandleQt.cpp:156
> +	   blobRegistry().loadResourceSynchronously(request, error, response,
data);

Hmm, shouldn't this "handle" the case if BlogRegistryImpl::shouldLoadResource
returning false (i.e. the cause of loadResourceSynchronously returning false) ?