[webkit-reviews] review denied: [Bug 97652] [EFL][WK2] Enable WebGL : [Attachment 169592] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 21 23:07:02 PDT 2012


Simon Hausmann <hausmann at webkit.org> has denied Regina Chung
<heejin.r.chung at samsung.com>'s request for review:
Bug 97652: [EFL][WK2] Enable WebGL
https://bugs.webkit.org/show_bug.cgi?id=97652

Attachment 169592: Patch
https://bugs.webkit.org/attachment.cgi?id=169592&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169592&action=review


r- because of incorrect licensing/authorship

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:206
> +#if USE(GRAPHICS_SURFACE)
> +void GraphicsContext3DPrivate::createGraphicsSurfaces(const IntSize& size)
> +{
> +    if (size.isEmpty())
> +	   m_graphicsSurface.clear();
> +    else
> +	   m_graphicsSurface = GraphicsSurface::create(size, m_surfaceFlags);
> +}
> +
> +uint32_t GraphicsContext3DPrivate::copyToGraphicsSurface()
> +{
> +    if (!m_graphicsSurface)
> +	   return 0;
> +
> +    makeContextCurrent();
> +    m_graphicsSurface->copyFromTexture(m_context->m_texture, IntRect(0, 0,
m_context->m_currentWidth, m_context->m_currentHeight));
> +    return m_graphicsSurface->swapBuffers();
> +}
> +
> +GraphicsSurfaceToken GraphicsContext3DPrivate::graphicsSurfaceToken() const
> +{
> +    return m_graphicsSurface->exportToken();
> +}
> +#endif

This looks like code that we could put into GraphicsContext3D.cpp if it's 100%
identical between Qt and EFL.

> Source/WebCore/platform/graphics/surfaces/efl/GraphicsSurfaceEfl.cpp:2
> + * Copyright (C) 2012 Samsung Electronics

This file is a 90% copy of surfaces/qt/GraphicsSurfaceGLX.cpp. If you decide to
fork it like this, then you need to retain the existing license and authorship.


But I suggest to merge the efforts, i.e. create
surfaces/glx/GraphicsSurfaceGLX.cpp with the little #ifdef'ed glue code
remaining for interaction with the toolkit GL bits.


More information about the webkit-reviews mailing list