[webkit-reviews] review denied: [Bug 99478] Lazy init timeout flag in ResourceErrorMac : [Attachment 168974] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Dominik Röttsches (drott)
<dominik.rottsches at intel.com>'s request for review:
Bug 99478: Lazy init timeout flag in ResourceErrorMac
https://bugs.webkit.org/show_bug.cgi?id=99478

Attachment 168974: Patch
https://bugs.webkit.org/attachment.cgi?id=168974&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168974&action=review


r-, because this breaks setIsTimeout().

> Source/WebCore/platform/network/ResourceErrorBase.h:50
>      bool isCancellation() const { return m_isCancellation; }

Notably, we don't need lazyInit() here.

> Source/WebCore/platform/network/ResourceErrorBase.h:53
>      void setIsTimeout(bool isTimeout) { m_isTimeout = isTimeout; }
> -    bool isTimeout() const { return m_isTimeout; }
> +    bool isTimeout() const { lazyInit(); return m_isTimeout; }

This means that even after a setIsTimeout(true) call, isTimeout() might return
false. That's not an intuitively correct behavior.