[webkit-reviews] review granted: [Bug 95833] [GStreamer] GstBuffer ref race in WebKitWebAudioSrcLoop : [Attachment 167826] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 95833: [GStreamer] GstBuffer ref race in WebKitWebAudioSrcLoop
https://bugs.webkit.org/show_bug.cgi?id=95833

Attachment 167826: Patch
https://bugs.webkit.org/attachment.cgi?id=167826&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=167826&action=review


Alright, thanks a lot Zan :) We should indeed port this code to 1.0 soon. I
started a branch but haven't got far yet... too busy :(

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:325

> +	   GstBuffer* channelBuffer = gst_buffer_new_and_alloc(bufferSize);

It'd be good to have an ASSERT(channelBuffer) here I think