[webkit-reviews] review requested: [Bug 98715] [EFL] Enable -Werror for the EFL port : [Attachment 167682] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 8 21:23:53 PDT 2012


Laszlo Gombos <laszlo.gombos at webkit.org> has asked  for review:
Bug 98715: [EFL] Enable -Werror for the EFL port
https://bugs.webkit.org/show_bug.cgi?id=98715

Attachment 167682: proposed patch
https://bugs.webkit.org/attachment.cgi?id=167682&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
Treat all warnings as errors, except the "unused parameter" warning. The
"unused parameter" warning is not turned on for other ports as warning, so that
will require some discussion with the other ports. 

Removed the ANOTHER_BRICK_IN_THE define as I do not think that is used (I found
it confusing to have the define in the build logs passed on CLI to the
compiler).


More information about the webkit-reviews mailing list