[webkit-reviews] review denied: [Bug 98499] Page popup should be smarter about its layout : [Attachment 167677] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 98499: Page popup should be smarter about its layout
https://bugs.webkit.org/show_bug.cgi?id=98499

Attachment 167677: Patch
https://bugs.webkit.org/attachment.cgi?id=167677&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167677&action=review


> Source/WebCore/ChangeLog:12
> +	   Test: platform/chromium/fast/forms/date/page-popup-adjust-rect.html

Need to udpate

> Source/WebCore/Resources/pagepopups/pickerCommon.js:74
> +Rect.intersection = function(rect1, rect2) {
> +    var x = Math.min(rect1.x, rect2.x);
> +    var maxX = Math.max(rect1.maxX, rect2.maxX);
> +    var y = Math.min(rect1.y, rect2.y);
> +    var maxY = Math.max(rect1.maxY, rect2.maxY);
> +    var width = maxX - x;
> +    var height = maxY - y;
> +    return new Rect(x, y, width, height);

This implementation is not "intersection", but "union".

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:114
> +#endif

nit: ColorChooserUIControler..cpp and DateTimeChooserImpl.cpp should share some
code.

> LayoutTests/ChangeLog:9
> +	   *
platform/chromium/fast/forms/page-popup/page-popup-adjust-rect-expected.txt:
Added.
> +	   *
platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html: Added.

should skip it in platform/chromium-android/TestExpectation

>
LayoutTests/platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html
:45
> +    shouldBe('popupWindow.adjustWindowRect(30, 10, 30, 10).toString()',
'"Rect(0,0,30,10)"');

You may use shouldBeEqualToString() to avoid nested quotes.