[webkit-reviews] review denied: [Bug 93922] [Shadow DOM] Insertion points need resetStyleInheritance : [Attachment 167277] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 93922: [Shadow DOM] Insertion points need resetStyleInheritance
https://bugs.webkit.org/show_bug.cgi?id=93922

Attachment 167277: Patch
https://bugs.webkit.org/attachment.cgi?id=167277&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167277&action=review


> Source/WebCore/ChangeLog:8
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).

Oops :)

> Source/WebCore/css/StyleResolver.cpp:1232
> +    for ( ; insertionPoint; ) {
> +	   InsertionPoint* youngerInsertionPoint =
shadow->insertionPointFor(insertionPoint);
> +	   if (!youngerInsertionPoint)
> +	       break;
> +	   insertionPoint = youngerInsertionPoint;
> +    }

This seems forced. Can you help me understand why the styles of the insertion
point wouldn't implicitly have this information? Presumably, their styles have
already been computed and they already have the correctly reset inheritance.

> LayoutTests/ChangeLog:8
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).

Oops :)

>
LayoutTests/fast/dom/shadow/insertion-point-resetStyleInheritance-expected.txt:
10
> +FAIL
window.getComputedStyle(document.getElementById("reset-style-inheritance-dynami
c").firstChild).color should be rgb(0, 0, 0). Was rgb(255, 238, 238).

Why'd we fail this?