[webkit-reviews] review granted: [Bug 97266] Deleting across multiple paragraphs can change the style of surrounding text : [Attachment 167356] Fixes the bug
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 5 11:17:59 PDT 2012
Levi Weintraub <leviw at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 97266: Deleting across multiple paragraphs can change the style of
surrounding text
https://bugs.webkit.org/show_bug.cgi?id=97266
Attachment 167356: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=167356&action=review
------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167356&action=review
Looks good. We talked in person.
> Source/WebCore/editing/EditingStyle.cpp:1027
> - if (node->isStyledElement()) {
> + if (node->isStyledElement() && !isMailBlockquote(node)) {
I understand this change, but wish there were explanation in the changelog.
> LayoutTests/ChangeLog:8
> + Added a regerssion test and rebaselined tests.
like smfr said ;)
More information about the webkit-reviews
mailing list