[webkit-reviews] review granted: [Bug 88834] If Node X is reachable from JavaScript, all Nodes in the same tree should be kept alive : [Attachment 167240] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 88834: If Node X is reachable from JavaScript, all Nodes in the same tree
should be kept alive
https://bugs.webkit.org/show_bug.cgi?id=88834

Attachment 167240: Patch
https://bugs.webkit.org/attachment.cgi?id=167240&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
r+ to this patch as is for JSC, pending adding Kentaro's changes to support V8.

Looking at the test cases, I see test coverage (in gc-12) where a wrapper is
created on a node in a disconnected subtree, ensuring that the parent remains
alive. I think we discussed at least one more possible route to this problem,
where a singleton disconnected node could be given children and became a root.
Is this a real problem, is it possible to write a test case, and is it covered
by one of these test cases?