[webkit-reviews] review granted: [Bug 61675] <input> size attribute should throw INDEX_SIZE_ERR when set to 0 : [Attachment 167243] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 4 23:29:49 PDT 2012


Kent Tamura <tkent at chromium.org> has granted Kunihiko Sakamoto
<ksakamoto at chromium.org>'s request for review:
Bug 61675: <input> size attribute should throw INDEX_SIZE_ERR when set to 0
https://bugs.webkit.org/show_bug.cgi?id=61675

Attachment 167243: Patch 2
https://bugs.webkit.org/attachment.cgi?id=167243&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167243&action=review


> Source/WebCore/ChangeLog:19
> +	   * html/HTMLInputElement.cpp:
> +	   (WebCore::HTMLInputElement::setSize):
> +	   * html/HTMLInputElement.h:
> +	   (HTMLInputElement):
> +	   * html/HTMLInputElement.idl:

You had better add per-file / per-function comments as possible.


More information about the webkit-reviews mailing list