[webkit-reviews] review granted: [Bug 98140] check-webkit-style can't handle qt-arm, qt-win, qt-mac, qt-5.0, qt-5.0-wk1 and qt-5.0-wk2 TestExpecatations : [Attachment 166752] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 98140: check-webkit-style can't handle qt-arm, qt-win, qt-mac, qt-5.0,
qt-5.0-wk1 and qt-5.0-wk2 TestExpecatations
https://bugs.webkit.org/show_bug.cgi?id=98140

Attachment 166752: Patch
https://bugs.webkit.org/attachment.cgi?id=166752&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems OK.  I found qt's layout test fallback confusing (and different from all
the other ports) so I didn't implement support for it in the original NRWT
conversion.  I (perhaps naively) hoped that they'd move to a naming
system/fallback more similar to the other ports.  But it's also possible I
simply mis-understood.	In any case, someone just needs to implement proper Qt
port fallback for NRWT and then we can remove qt-arm's ORWT usage, and fix the
bugs like this one. :)