[webkit-reviews] review denied: [Bug 98186] [WK2] PageViewportController.cpp is supposed to be a generic WebKit2 file but only works with Qt port. : [Attachment 166730] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 2 14:39:22 PDT 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has denied Hugo Parente Lima
<hugo.lima at openbossa.org>'s request for review:
Bug 98186: [WK2] PageViewportController.cpp is supposed to be a generic WebKit2
file but only works with Qt port.
https://bugs.webkit.org/show_bug.cgi?id=98186

Attachment 166730: Patch
https://bugs.webkit.org/attachment.cgi?id=166730&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166730&action=review


Better to use FloatSize::scale explicitly

> Source/WebCore/platform/graphics/FloatSize.h:188
> +inline FloatSize operator/(const FloatSize& a, const float& b)

const float& -> float


More information about the webkit-reviews mailing list