[webkit-reviews] review granted: [Bug 98091] IndexedDB: Don't wedge if page reloads with pending upgradeneeded : [Attachment 166586] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 98091: IndexedDB: Don't wedge if page reloads with pending upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=98091

Attachment 166586: Patch
https://bugs.webkit.org/attachment.cgi?id=166586&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166586&action=review


> LayoutTests/storage/indexeddb/resources/dont-wedge.js:26
> +    else
> +	   debug("In content_shell this deleteDatabase request is blocked
temporarily");

Nit: I would make this comment more general. Rather than name content_shell,
maybe say in a multiprocess implementation, this deleteDatabase request can be
blocked temporarily.  Someone may want to run this test in another browser or
in a few years, we may be using something other than content_shell.