[webkit-reviews] review granted: [Bug 98149] MediaStream API: RTCPeerConnection should send down its handler via the FrameLoaderClient directly after creation. : [Attachment 166673] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 98149: MediaStream API: RTCPeerConnection should send down its handler via
the FrameLoaderClient directly after creation.
https://bugs.webkit.org/show_bug.cgi?id=98149

Attachment 166673: Patch
https://bugs.webkit.org/attachment.cgi?id=166673&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166673&action=review


> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:139
> +    if (!document || !(document->frame())) {

document will always be non-0 here.

>
Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.c
pp:61
> +WebKit::WebRTCPeerConnectionHandler*
RTCPeerConnectionHandlerChromium::toWebRTCPeerConnectionHandler(RTCPeerConnecti
onHandler* handler)
> +{
> +    return
static_cast<RTCPeerConnectionHandlerChromium*>(handler)->m_webHandler.get();
> +}

I probably would have just added a public accessor for m_webHandler and had
FrameLoaderClientImpl do the static_cast, but this is ok too.