[webkit-reviews] review granted: [Bug 97825] AX: labelForElement is slow when there are a lot of DOM elements : [Attachment 166411] Fix compile

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 97825: AX: labelForElement is slow when there are a lot of DOM elements
https://bugs.webkit.org/show_bug.cgi?id=97825

Attachment 166411: Fix compile
https://bugs.webkit.org/attachment.cgi?id=166411&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166411&action=review


I think it looks good from an accessibility perspective. We might want to get
someone more familiar with DOM code to ensure that there aren't any other edge
cases missed and that virtualizing willModifyAttribute is OK

> Source/WebCore/ChangeLog:19
> +	   (WebCore):

remove extraneous (WebCore): lines

> Source/WebCore/dom/Document.cpp:633
> +	   topDocument()->m_axObjectCache->documentDestroyed(this);

can we put these two lines into a method like "cleanupAccessibility()" and put
clearAXObjectCache() logic in that too

> Source/WebCore/dom/Element.h:320
> +    virtual void willModifyAttribute(const QualifiedName&, const
AtomicString& oldValue, const AtomicString& newValue);

we should confirm that making this virtual won't have terrible performance
implications