[webkit-reviews] review denied: [Bug 97940] r129934 lacks png baselines for the new test : [Attachment 166468] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 09:38:11 PDT 2012


Ojan Vafai <ojan at chromium.org> has denied Brian Salomon <bsalomon at google.com>'s
request for review:
Bug 97940: r129934 lacks png baselines for the new test
https://bugs.webkit.org/show_bug.cgi?id=97940

Attachment 166468: Patch
https://bugs.webkit.org/attachment.cgi?id=166468&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166468&action=review


The change looks good. Can you include the new expected results for whichever
platform you're running on?

> LayoutTests/ChangeLog:8
> +	   This eliminates some space characters from the test output.

Can you give a bit more detail here? Specifically, saying that this is so the
expected result files won't depend on text rendering layout.


More information about the webkit-reviews mailing list