[webkit-reviews] review granted: [Bug 103773] Late-loading stylesheets can cause composited layers to be blank : [Attachment 177024] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 103773: Late-loading stylesheets can cause composited layers to be blank
https://bugs.webkit.org/show_bug.cgi?id=103773

Attachment 177024: Patch
https://bugs.webkit.org/attachment.cgi?id=177024&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177024&action=review


> Source/WebCore/ChangeLog:9
> +	   is pending, which is done to avoid a FOUC. When the stylesheet
finally loaded,

Probably spell it out?

> Source/WebCore/rendering/RenderLayerCompositor.h:148
> +    // Repaint parts of all composited layers that intersect the given
absolute rectangle (or the entire layer if the pointer is null).
> +    void repaintCompositedLayers(const IntRect* = 0);

This mechanism makes for some slightly unusual looking code elsewhere...

> Source/WebCore/rendering/RenderView.h:-84
> -    virtual void repaintViewRectangle(const LayoutRect&, bool immediate =
false) const;
> +    void repaintViewRectangle(const LayoutRect&, bool immediate = false)
const;
>      // Repaint the view, and all composited layers that intersect the given
absolute rectangle.
>      // FIXME: ideally we'd never have to do this, if all repaints are
container-relative.
> -    virtual void repaintRectangleInViewAndCompositedLayers(const
LayoutRect&, bool immediate = false);

These weren't virtual for a reason?