[webkit-reviews] review granted: [Bug 103606] WebGL: Add a class to abstract the status of the Image in texImage2D() and texSubImage2D() : [Attachment 176925] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Jun Jiang
<jun.a.jiang at intel.com>'s request for review:
Bug 103606: WebGL: Add a class to abstract the status of the Image in
texImage2D() and texSubImage2D()
https://bugs.webkit.org/show_bug.cgi?id=103606

Attachment 176925: Patch
https://bugs.webkit.org/attachment.cgi?id=176925&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176925&action=review


Looks great. Thank you for pushing through this change. A couple of minor nits
which are not blockers for committing in my opinion. If you wouldn't mind,
please clean them up in a subsequent patch. Submitting this to the commit queue
for you. r=me

> Source/WebCore/platform/graphics/GraphicsContext3D.h:877
> +    // according to the given format and type, and obeying the flipY and
premultiplyAlpha flags.

Typo: premultiplyAlpha -> AlphaOp

> Source/WebCore/platform/graphics/GraphicsContext3D.h:900
> +	   // Return true upon success

Please use complete sentences in comments (end each sentence with a period).