[webkit-reviews] review granted: [Bug 103291] PDFPlugin: Page scale factor should affect subframe PDFs : [Attachment 176078] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 27 09:54:01 PST 2012


Darin Adler <darin at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 103291: PDFPlugin: Page scale factor should affect subframe PDFs
https://bugs.webkit.org/show_bug.cgi?id=103291

Attachment 176078: patch
https://bugs.webkit.org/attachment.cgi?id=176078&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176078&action=review


> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:323
> +    float newScaleFactor = controller()->contentsScaleFactor();

Is float the correct type here?


More information about the webkit-reviews mailing list