[webkit-reviews] review granted: [Bug 103290] Ensure that WebPageProxy's notion of pageScaleFactor is reset on didCommitLoad : [Attachment 176077] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 103290: Ensure that WebPageProxy's notion of pageScaleFactor is reset on
didCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=103290

Attachment 176077: patch
https://bugs.webkit.org/attachment.cgi?id=176077&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176077&action=review


Can you make a test case?

I’m OK with this change, but it seems to be an indirect way to solve the
problem, and I suspect there’s a better way.

> Source/WebKit2/ChangeLog:19
> +	   instead of reaching into WebCore immediately.

immediately -> directly

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:479
> +	      
webPage->send(Messages::WebPageProxy::PageScaleFactorDidChange(1));

Is it really appropriate to send this message after every single load? These
redundant messages don’t seem to be conveying information. Can’t the other
process determine this without having to receive a cross-process message? There
must be a better way to solve this. It seems bogus to just send extra scale
factor did change messages when the scale factor did not change.