[webkit-reviews] review denied: [Bug 101349] [GStreamer] Floating reference handling fix : [Attachment 175872] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Thiago Santos
<thiago.sousa.santos at collabora.com>'s request for review:
Bug 101349: [GStreamer] Floating reference handling fix
https://bugs.webkit.org/show_bug.cgi?id=101349

Attachment 175872: Patch
https://bugs.webkit.org/attachment.cgi?id=175872&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=175872&action=review


Awesome, thanks Thiago! Now just the ChangeLog to fix up and the missing
include to add!

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:181

> +    priv->sourcePad = webkitGstGhostPadFromStaticTemplate(&srcTemplate,
"src", 0);

GStreamerVersioning.h include is missing I think. BTW this code is not yet
enabled by default in the build, you need to use the --web-audio build-webkit
option. I have a patch almost ready for the 1.0 port to upload soon :)