[webkit-reviews] review granted: [Bug 103172] implement the HTML <main> element : [Attachment 175877] patch to add <main>
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 25 02:25:18 PST 2012
Steve Faulkner <faulkner.steve at gmail.com> has granted review:
Bug 103172: implement the HTML <main> element
https://bugs.webkit.org/show_bug.cgi?id=103172
Attachment 175877: patch to add <main>
https://bugs.webkit.org/attachment.cgi?id=175877&action=review
------- Additional Comments from Steve Faulkner <faulkner.steve at gmail.com>
changes made to add main support
mapped LandamrkMainRole to mainTag
[WebCore\accessibility\AccessibilityRenderObject.cpp]
Line 2485 : if (node && node->hasTagName(mainTag))
Line 2486 : return LandmarkMainRole;
added mainTag as a blockTag
[WebCore\WebKit\editing\FormatBlockCommand.cpp]
Line 139 : blockTags.add(mainTag);
added mainTag as a stackItem
[WebCore\WebKit\html\parser\HTMLStackItem.h]
Line 171 : || tagName == HTMLNames::mainTag
added mainTag in tree builder
[WebCore\WebKit\html\parser\HTMLTreeBuilder.cpp]
Line 714 : || token->name() == mainTag
Line 1726 : || token->name() == mainTag
added main to following style declaration:
[WebCore\css\html.css]
article, aside, footer, header, hgroup, main, nav, section {
display: block
}
More information about the webkit-reviews
mailing list