[webkit-reviews] review granted: [Bug 102889] WebSocket's MessageEvent.origin attribute is an empty string : [Attachment 175758] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 102889: WebSocket's MessageEvent.origin attribute is an empty string
https://bugs.webkit.org/show_bug.cgi?id=102889

Attachment 175758: Patch
https://bugs.webkit.org/attachment.cgi?id=175758&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175758&action=review


Looks OK.

> LayoutTests/http/tests/websocket/tests/hybi/send-onmessage-origin.html:21
> +var FirstMessageToSend = "This is the first message to send to the server.";

> +var SecondMessageToSend = "This is the second.";

Sorry for nit-picking. WebKit uses camelCase even for constants. So this could
be firstMessageToSend and secondMessageToSend.