[webkit-reviews] review granted: [Bug 101479] [sh4] JavaScriptCore JIT build is broken for sh4 arch : [Attachment 175743] Add missing implementation in SH4 JIT

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Julien Brianceau
<jbrianceau at nds.com>'s request for review:
Bug 101479: [sh4] JavaScriptCore JIT build is broken for sh4 arch
https://bugs.webkit.org/show_bug.cgi?id=101479

Attachment 175743: Add missing implementation in SH4 JIT
https://bugs.webkit.org/attachment.cgi?id=175743&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=175743&action=review


>> Source/JavaScriptCore/assembler/SH4Assembler.h:2097
>> +	static void printInstr(uint16_t opc, unsigned int size, bool
isdoubleInst = true) { };
> 
> Omit int when using unsigned	[runtime/unsigned] [1]

The style queue is right.  Can you fix this style bug and submit for cq? (or
commit if you have the privileges).  R=me other than the style.

>> Source/JavaScriptCore/assembler/SH4Assembler.h:2098
>> +	static void printBlockInstr(uint16_t* first, unsigned int offset, int
nbInstr) { };
> 
> Omit int when using unsigned	[runtime/unsigned] [1]

Ditto.