[webkit-reviews] review granted: [Bug 102210] Web Inspector: [Timeline] "Show CPU activity on the ruler" settings checkbox does not take effect until Inspector restart : [Attachment 175590] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted eustas.bug at gmail.com's
request for review:
Bug 102210: Web Inspector: [Timeline] "Show CPU activity on the ruler" settings
checkbox does not take effect until Inspector restart
https://bugs.webkit.org/show_bug.cgi?id=102210

Attachment 175590: Patch
https://bugs.webkit.org/attachment.cgi?id=175590&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175590&action=review


> Source/WebCore/inspector/front-end/TimelinePanel.js:138
> +    this._mainThreadMonitoringEnabled =
WebInspector.settings.showCpuOnTimelineRuler.get() &&
Capabilities.timelineCanMonitorMainThread;

I would check for capability first.

> Source/WebCore/inspector/front-end/TimelinePanel.js:160
> +	   var mainThreadMonitoringEnabled =
WebInspector.settings.showCpuOnTimelineRuler.get() &&
Capabilities.timelineCanMonitorMainThread;

I don't think you need a capability check here.