[webkit-reviews] review denied: [Bug 102813] Web Inspector: DataGrid: avoid repetitive access to node data field. : [Attachment 175214] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 22 12:26:01 PST 2012
Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 102813: Web Inspector: DataGrid: avoid repetitive access to node data
field.
https://bugs.webkit.org/show_bug.cgi?id=102813
Attachment 175214: Patch
https://bugs.webkit.org/attachment.cgi?id=175214&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175214&action=review
> Source/WebCore/ChangeLog:9
> + Each access to "data" causes construction of object that
Could you explain what object is constructed? I can only see
get data()
{
return this._data;
},
in WebInspector.DataGridNode.prototype. This does not cost anything.
More information about the webkit-reviews
mailing list