[webkit-reviews] review granted: [Bug 102802] REGRESSION (r128633): td changes size during re-layout of table although it shouldn't : [Attachment 175688] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 22 11:43:39 PST 2012


Ojan Vafai <ojan at chromium.org> has granted Julian Pastarmov
<pastarmovj at chromium.org>'s request for review:
Bug 102802: REGRESSION (r128633): td changes size during re-layout of table
although it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=102802

Attachment 175688: Patch
https://bugs.webkit.org/attachment.cgi?id=175688&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175688&action=review


Looks great. Please fix the doctype issue before committing.

> LayoutTests/fast/table/nested-tables-with-div-offset.html:1
> +<!DOCTYPE xhtml>

No need to include the doctype here. We only include a doctype when we're
trying to get standards mode. Even then we only use the html doctype of
<!DOCTYPE html>.


More information about the webkit-reviews mailing list