[webkit-reviews] review denied: [Bug 103040] Web Inspector: Can we provide an interface to update the "Metrics" and "Highlight Overlay" according to the change of inspected page. : [Attachment 175628] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has denied Peter Wang
<peter.wang at torchmobile.com.cn>'s request for review:
Bug 103040: Web Inspector: Can we provide an interface to update the "Metrics"
and "Highlight	Overlay" according to the change of inspected page.
https://bugs.webkit.org/show_bug.cgi?id=103040

Attachment 175628: Patch
https://bugs.webkit.org/attachment.cgi?id=175628&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175628&action=review


We do not land unused code. Please also describe how this change is intended to
remedy the problem described.

As a side note, rotating a mobile device updates media query results, which is
already reported through the CSS.mediaQueryResultChanged event.

> Source/WebCore/inspector/InspectorDOMAgent.h:159
> +    void documentUpated();

Typo: should be "documentUpdated"