[webkit-reviews] review granted: [Bug 102896] Coordinated Graphics: refactor changing children code in CoordinatedGraphicsLayer. : [Attachment 175366] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 102896: Coordinated Graphics: refactor changing children code in
CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=102896

Attachment 175366: Patch
https://bugs.webkit.org/attachment.cgi?id=175366&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175366&action=review


> Source/WebKit2/ChangeLog:14
> +	   When changing children, we don't need to sync a layer state. We were
confused
> +	   that we have to send a parent layer id to UI Process, but r133605
clarified
> +	   passing the parent id is not necessary. So this patch removes
> +	   didChangeLayerState() in methods which change children.
> +
> +	   In addition, purgeBackingStores() does not need to call
didChangeChildren()
> +	   because purgeBackingStores() does not change children.

I wouldn't say we were confused, in the past behavior of GraphicsLayer we did
have to send the parent.
I would reword this to say "There is no more need to send the parent ID every
time the layer tree hierarchy changes."