[webkit-reviews] review denied: [Bug 102802] REGRESSION (r128633): td changes size during re-layout of table although it shouldn't : [Attachment 175422] Patch

Wed Nov 21 06:59:03 PST 2012

jochen at chromium.org has denied Julian Pastarmov <pastarmovj at chromium.org>'s
request for review:
Bug 102802: REGRESSION (r128633): td changes size during re-layout of table
although it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=102802

Attachment 175422: Patch
https://bugs.webkit.org/attachment.cgi?id=175422&action=review

------- Additional Comments from jochen at chromium.org
I would recommend turning this into a reftest.

Also, it should be possible to find a smaller test case.

View in context: https://bugs.webkit.org/attachment.cgi?id=175422&action=review

> LayoutTests/fast/dom/jumping-box-test.html:2
> +  <head>

please format the html file according the the webkit-style as well

> LayoutTests/fast/dom/jumping-box-test.html:83
> +    eventSender.mouseMoveTo(10,10);

i don't think using the event sender is necessary, you could just change the
css in the onload handler.

Also, you should write the test such that it is possible to verify the result
when you run it in a browser (i.e. include a textual description of what it
does, and make sure you don't use objects like eventSender without first
checking whether they exist)