[webkit-reviews] review granted: [Bug 102774] [V8] Remove V8ParameterBase : [Attachment 175159] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 20 01:22:22 PST 2012
Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 102774: [V8] Remove V8ParameterBase
https://bugs.webkit.org/show_bug.cgi?id=102774
Attachment 175159: Patch
https://bugs.webkit.org/attachment.cgi?id=175159&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175159&action=review
> Source/WebCore/bindings/v8/V8StringResource.h:52
> +template <V8ParameterMode MODE = DefaultMode>
MODE -> Mode
> Source/WebCore/bindings/v8/V8StringResource.h:55
> + V8Parameter(v8::Local<v8::Value> object) : m_v8Object(object),
m_mode(Externalize), m_string() { }
Please split this up into multiple lines.
More information about the webkit-reviews
mailing list