[webkit-reviews] review denied: [Bug 102770] [V8] Move IsConstruct() checks of overloaded constructors to a better place : [Attachment 175142] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied	review:
Bug 102770: [V8] Move IsConstruct() checks of overloaded constructors to a
better place
https://bugs.webkit.org/show_bug.cgi?id=102770

Attachment 175142: Patch
https://bugs.webkit.org/attachment.cgi?id=175142&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
> fast/dom/call-a-constructor-as-a-function.html

This patch is wrong. We need to check if we're in a constructor or not before
sorting overloaded constructor callbacks. Otherwise, we cannot distinguish
'WebSocket()' from 'new WebSocket()'. 'WebSocket()' should be 'Constructor
cannot be called as a function' error, and 'new WebSocket()' should be 'Not
enough arguments' error.