[webkit-reviews] review granted: [Bug 102765] Remove unneeded null check in NodeRendererFactory::createRendererIfNeeded : [Attachment 175136] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 19 21:47:56 PST 2012
Ojan Vafai <ojan at chromium.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 102765: Remove unneeded null check in
NodeRendererFactory::createRendererIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=102765
Attachment 175136: Patch
https://bugs.webkit.org/attachment.cgi?id=175136&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175136&action=review
> Source/WebCore/dom/NodeRenderingContext.cpp:255
> + ASSERT(m_context.parentRenderer());
Can you move this line to be above the if/else. It makes more sense to me to
assert before the line that depends on the assert.
More information about the webkit-reviews
mailing list