[webkit-reviews] review denied: [Bug 102761] Call directly RenderBlock::deleteLineBoxTree : [Attachment 175126] Proposed patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Igor Trindade Oliveira
<igor.oliveira at webkit.org>'s request for review:
Bug 102761: Call directly RenderBlock::deleteLineBoxTree
https://bugs.webkit.org/show_bug.cgi?id=102761

Attachment 175126: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=175126&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175126&action=review


Certainly the coding of this change is fine. However, I am concerned that we
will start seeing flakiness in the 'fast/repaint' test cases again.  Please
revise the ChangeLog (and/or the bug) to indicate why this is no longer a
concern and I'll happily r+ it for you.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:-1814
> -	   // crashes for fast/repaint tests.

What has changed since this comment was made that makes it possible to use
'deleteLineBoxTree' directly?  Is the comment no longer true -- i.e., have
other bug fixes have rendered it unnecessary to avoid calling the method
directly?  If so, please indicate this in the ChangeLog. Ideally, we would
identify the change that fixed the original problem but that's not critical.

On the other hand, if we have no reason to believe that the crash is now
resolved, I don't think it wise to move to this new implementation.