[webkit-reviews] review denied: [Bug 102396] Move test name splitting and path separator to a separate module : [Attachment 174460] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 15 17:47:17 PST 2012


Dirk Pranke <dpranke at chromium.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 102396: Move test name splitting and path separator to a separate module
https://bugs.webkit.org/show_bug.cgi?id=102396

Attachment 174460: Patch
https://bugs.webkit.org/attachment.cgi?id=174460&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
I'm sorry, I guess I wasn't clear in the prior comments. I do not want to
create a module concerned solely with test names. Please leave all of this code
in the Port object for now, until we can move *all* of the logic concerning
handling tests out into another module (at which point, "test_name" won't be a
good name for it).


More information about the webkit-reviews mailing list