[webkit-reviews] review denied: [Bug 102401] Move natural sorting to a separate module : [Attachment 174468] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 102401: Move natural sorting to a separate module
https://bugs.webkit.org/show_bug.cgi?id=102401

Attachment 174468: Patch
https://bugs.webkit.org/attachment.cgi?id=174468&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174468&action=review


> Tools/Scripts/webkitpy/common/natural_order.py:34
> +def _natural_sort_key(string_to_split):

If we're going to split natural_sort into a separate module, it should *only*
deal with natural sorting, and not have anything to do with "test_name"s at
all. Also, depending on how the rest of this code shakes out, it might be that
we can move the natural_sort code into port/base.py for now (until we move all
of the test-handling logic out) and avoid needing to reference things from
three different modules.