[webkit-reviews] review granted: [Bug 102122] [EFL][WK2] New window size should consult the window attributes : [Attachment 173996] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Yael
<yael at webkit.org>'s request for review:
Bug 102122: [EFL][WK2] New window size should consult the window attributes
https://bugs.webkit.org/show_bug.cgi?id=102122

Attachment 173996: Patch
https://bugs.webkit.org/attachment.cgi?id=173996&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173996&action=review


> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:844
> +    unsigned int width = ref ?
WKDoubleGetValue(static_cast<WKDoubleRef>(ref)) : 0;

style says to just use "unsigned" ie. no int

> Tools/MiniBrowser/efl/main.c:187
> -	   Browser_Window *window = window_create(DEFAULT_URL);
> +	   Browser_Window *window = window_create(DEFAULT_URL, 0, 0);

// 0 equals default.