[webkit-reviews] review granted: [Bug 101949] [Chromium] Refactor theme font lookup into a factory : [Attachment 173739] Fixes style issues
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 13 14:48:37 PST 2012
Tony Chang <tony at chromium.org> has granted Scott Violet <sky at google.com>'s
request for review:
Bug 101949: [Chromium] Refactor theme font lookup into a factory
https://bugs.webkit.org/show_bug.cgi?id=101949
Attachment 173739: Fixes style issues
https://bugs.webkit.org/attachment.cgi?id=173739&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173739&action=review
> Source/WebCore/rendering/RenderThemeChromiumFontProviderLinux.cpp:51
> +void RenderThemeChromiumFontProvider::getFont(int propId, FontDescription&
fontDescription)
Nit: It's not that common to prefix a method with 'get' in WebKit. Something
like initializeSystemFont might be more descriptive.
More information about the webkit-reviews
mailing list