[webkit-reviews] review granted: [Bug 101985] JSC: JSEventListener should not access its JSFunction if its wrapper is gone : [Attachment 173909] Fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 09:59:14 PST 2012


Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 101985: JSC: JSEventListener should not access its JSFunction if its
wrapper is gone
https://bugs.webkit.org/show_bug.cgi?id=101985

Attachment 173909: Fix.
https://bugs.webkit.org/attachment.cgi?id=173909&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Your ChangeLog should describe the case you discovered that makes the old
ASSERT invalid. That will also explain why you didn't write a regression test.
Otherwise, a future reader won't have any way to know why our old assumption
was invalid.


More information about the webkit-reviews mailing list